refactor to comply with current ansible-lint and sanity guidelines

Signed-off-by: Adam Miller <admiller@redhat.com>

tests/integration/targets/firewalld/tasks/protocol_test_cases.yml

@@ -1,3 +1,4 @@
+---
 # Test playbook for the firewalld module - protocol operations
 # (c) 2022, Robért S. Guhr <rguhr@cronon.net>
 
@@ -16,50 +17,50 @@
 # You should have received a copy of the GNU General Public License
 # along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
 
-- name: firewalld protocol test permanent enabled
-  firewalld:
+- name: Firewalld protocol test permanent enabled
+  ansible.posix.firewalld:
     protocol: ospf
     permanent: true
     state: enabled
   register: result
 
-- name: assert firewalld protocol test permanent enabled worked
-  assert:
+- name: Assert firewalld protocol test permanent enabled worked
+  ansible.builtin.assert:
     that:
-    - result is changed
+      - result is changed
 
-- name: firewalld protocol test permanent enabled rerun (verify not changed)
-  firewalld:
+- name: Firewalld protocol test permanent enabled rerun (verify not changed)
+  ansible.posix.firewalld:
     protocol: ospf
     permanent: true
     state: enabled
   register: result
 
-- name: assert firewalld protocol test permanent enabled rerun worked (verify not changed)
-  assert:
+- name: Assert firewalld protocol test permanent enabled rerun worked (verify not changed)
+  ansible.builtin.assert:
     that:
-    - result is not changed
+      - result is not changed
 
-- name: firewalld protocol test permanent disabled
-  firewalld:
+- name: Firewalld protocol test permanent disabled
+  ansible.posix.firewalld:
     protocol: ospf
     permanent: true
     state: disabled
   register: result
 
-- name: assert firewalld protocol test permanent disabled worked
-  assert:
+- name: Assert firewalld protocol test permanent disabled worked
+  ansible.builtin.assert:
     that:
-    - result is changed
+      - result is changed
 
-- name: firewalld protocol test permanent disabled rerun (verify not changed)
-  firewalld:
+- name: Firewalld protocol test permanent disabled rerun (verify not changed)
+  ansible.posix.firewalld:
     protocol: ospf
     permanent: true
     state: disabled
   register: result
 
-- name: assert firewalld protocol test permanent disabled rerun worked (verify not changed)
-  assert:
+- name: Assert firewalld protocol test permanent disabled rerun worked (verify not changed)
+  ansible.builtin.assert:
     that:
-    - result is not changed
+      - result is not changed