refactor to comply with current ansible-lint and sanity guidelines

Signed-off-by: Adam Miller <admiller@redhat.com>

tests/integration/targets/authorized_key/tasks/setup_steps.yml

@@ -1,37 +1,40 @@
+---
 # -------------------------------------------------------------
 # Setup steps
 - name: Clean up the working directory and files
-  file:
-    path: '{{ output_dir }}'
+  ansible.builtin.file:
+    path: "{{ output_dir }}"
     state: absent
 
 - name: Create the working directory
-  file:
-    path: '{{ output_dir }}'
+  ansible.builtin.file:
+    path: "{{ output_dir }}"
     state: directory
+    mode: "0744"
 
-- name: copy an existing file in place with comments
-  copy:
+- name: Copy an existing file in place with comments
+  ansible.builtin.copy:
     src: existing_authorized_keys
     dest: "{{ output_dir | expanduser }}/authorized_keys"
+    mode: "0600"
 
-- name: add multiple keys different order
-  authorized_key:
+- name: Add multiple keys different order
+  ansible.posix.authorized_key:
     user: root
     key: "{{ multiple_key_different_order_2 }}"
     state: present
     path: "{{ output_dir | expanduser }}/authorized_keys"
   register: result
 
-- name: get the file content
-  shell: cat "{{ output_dir | expanduser }}/authorized_keys"
-  changed_when: no
+- name: Get the file content
+  ansible.builtin.command: /bin/cat "{{ output_dir | expanduser }}/authorized_keys"
+  changed_when: false
   register: multiple_keys_existing
 
-- name: assert that the key was added and comments and ordering preserved
-  assert:
+- name: Assert that the key was added and comments and ordering preserved
+  ansible.builtin.assert:
     that:
-      - 'result.changed == True'
+      - result.changed == True
       - '"# I like candy" in multiple_keys_existing.stdout'
       - '"# I like candy" in multiple_keys_existing.stdout_lines[0]'
       - '"ssh-rsa DATA_BASIC 1@testing" in multiple_keys_existing.stdout'
@@ -41,19 +44,20 @@
 
 # start afresh
 
-- name: remove file foo.txt
-  file:
+- name: Remove file foo.txt
+  ansible.builtin.file:
     path: "{{ output_dir | expanduser }}/authorized_keys"
     state: absent
 
-- name: touch the authorized_keys file
-  file:
+- name: Touch the authorized_keys file
+  ansible.builtin.file:
     dest: "{{ output_dir }}/authorized_keys"
     state: touch
+    mode: "0600"
   register: result
 
-- name: assert that the authorized_keys file was created
-  assert:
+- name: Assert that the authorized_keys file was created
+  ansible.builtin.assert:
     that:
-      - 'result.changed == True'
-      - 'result.state == "file"'
+      - result.changed == True
+      - result.state == "file"