synchronize: fix changed status with link_dest (#812)

* synchronize: fix changed status with link_dest

With link_dest the module runs rsync with -vv, which also itemizes
unchanged files as '.f' followed by spaces. Any such line made the
module report no change, even when other files in the same run were
transferred, deleted or had their permissions updated.

Treat a line as unchanged only when it starts with a period and has no
attribute changes, which is how rsync lists files it did not touch.

Signed-off-by: Luca Marsella <marsluca7@gmail.com>
Assisted-by: Claude Opus 5.5

* synchronize: don't make link_dest test files world-readable

SonarCloud flags the new test tasks for granting access to others.
The test does not need it, so use 0750 and 0640 instead.

Signed-off-by: Luca Marsella <marsluca7@gmail.com>

* synchronize: read rsync markers only at the start of a line

The link_dest check split the whole output on the marker, so a file
name that contains the marker made a no-op sync report a change.

Signed-off-by: Luca Marsella <marsluca7@gmail.com>

---------

Signed-off-by: Luca Marsella <marsluca7@gmail.com>
This commit is contained in:
Luca Marsella
2026-11-16 16:16:54 +09:00
committed by GitHub
parent 4bd26a3cc6
commit 4daa61d294
3 changed files with 105 additions and 2 deletions
+4 -2
View File
@@ -632,8 +632,10 @@ def main():
return module.fail_json(msg=err, rc=rc, cmd=cmdstr)
if link_dest:
# a leading period indicates no change
changed = (changed_marker + '.') not in out
# -vv also itemizes unchanged items: a period, the file type, then
# spaces (e.g. '.f foo'). Every other itemized line is a change.
items = [line[len(changed_marker):] for line in out.splitlines() if line.startswith(changed_marker)]
changed = any(not (item.startswith('.') and item[2:3] == ' ') for item in items)
else:
changed = changed_marker in out